Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper

[David Hildenbrand]

On 16.07.21 14:46, tianxianting wrote:
> Do you interest in this patch? just little improvment:)

I am, especially when I'm cc'ed and aware of it ;)

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

One nit below

> 在 2021/7/13 下午11:38, Xianting Tian 写道:
> > From: Xianting Tian <xianting.tian@xxxxxxxxxxxxxxxxx>
> >
> > Use the helper virtio_find_vqs().
> >
> > Signed-off-by: Xianting Tian <xianting.tian@xxxxxxxxxxxxxxxxx>
> > ---
> >    drivers/virtio/virtio_balloon.c | 4 ++--
> >    1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> > index 510e931..18e0bf3 100644
> > --- a/drivers/virtio/virtio_balloon.c
> > +++ b/drivers/virtio/virtio_balloon.c
> > @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
> >    		callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
> >    	}
> >    
> > -	err = vb->vdev->config->find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX,
> > -					 vqs, callbacks, names, NULL, NULL);
> > +	err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
> > +				callbacks, names, NULL);
				^
we tend to indent this such that it is aligned with the line above (see 
the old code), unless the code becomes unreadable


--
Thanks,

David / dhildenb