Re: [PATCH 5.12 000/242] 5.12.18-rc1 review

From: Greg Kroah-Hartman
Date: Fri Jul 16 2021 - 14:03:03 EST


On Fri, Jul 16, 2021 at 06:40:15AM -0700, Guenter Roeck wrote:
> On 7/15/21 11:36 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.12.18 release.
> > There are 242 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sat, 17 Jul 2021 18:21:07 +0000.
> > Anything received after that time might be too late.
> >
>
> Building s390:defconfig ... failed
> --------------
> Error log:
> /bin/sh: arch/s390/kernel/vdso64/gen_vdso_offsets.sh: Permission denied
> /bin/sh: arch/s390/kernel/vdso32/gen_vdso_offsets.sh: Permission denied
> ...
>
> Original commit:
>
> diff --git a/arch/s390/kernel/vdso32/gen_vdso_offsets.sh b/arch/s390/kernel/vdso32/gen_vdso_offsets.sh
> new file mode 100755
> ^^^^^^
> index 000000000000..9c4f951e227d
> --- /dev/null
> +++ b/arch/s390/kernel/vdso32/gen_vdso_offsets.sh
>
> This commit:
>
> diff --git a/arch/s390/kernel/vdso32/gen_vdso_offsets.sh b/arch/s390/kernel/vdso32/gen_vdso_offsets.sh
> new file mode 100644
> ^^^^^^
> index 000000000000..9c4f951e227d
> --- /dev/null
> +++ b/arch/s390/kernel/vdso32/gen_vdso_offsets.sh
>
> Same with v5.13.y.

Ah crap. Quilt does not handle permissions like this. And really, we
shouldn't be doing that either in the kernel, I thought we fixed these
all up so that the executable bit did not have to be set.

Let me go dig...

thanks,

greg k-h