Re: [PATCH 1/2] ARM: at91: fix link error

[Claudiu.Beznea]

On 19.07.2021 15:40, Nicolas Ferre wrote:
> Hi Claudiu,
> 
> On 19/07/2021 at 10:03, Claudiu Beznea wrote:
>> PM support for SAMA7G5 has been submitted to mailing list before SAMA7G5
>> soc support thus the SAMA7G5 was not present in AT91 Kconfig file at
>> that moment. SoC support for SAMA7G5 hasn't added the proper PM flags to
>> Kconfig thus the link error bellow:
>>
>> arch/arm/mach-at91/sama7.o: In function `sama7_dt_device_init':
>> sama7.c:(.init.text+0x18): undefined reference to `sama7_pm_init'
>> make: *** [Makefile:1176: vmlinux] Error 1
>>
>> Add proper flags to AT91 Kconfig file to solve the issue.
>>
>> Fixes: 5617a08dd9e1 ("ARM: at91: pm: add pm support for SAMA7G5")
>> Fixes: 18d694ecd91e ("ARM: at91: add new SoC sama7g5")
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>> ---
>>   arch/arm/mach-at91/Kconfig | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
>> index f52b46bccd85..b09bb2279f7f 100644
>> --- a/arch/arm/mach-at91/Kconfig
>> +++ b/arch/arm/mach-at91/Kconfig
>> @@ -204,6 +204,9 @@ config ATMEL_PM
>>   config SOC_SAMA7
>>       bool
>>       select ARM_GIC
>> +    select ATMEL_PM if PM
>> +    select ATMEL_SDRAMC
>>       select MEMORY
>>       select SOC_SAM_V7
>> +    select SRAM if PM
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> 
> I squashed this patch in 18d694ecd91e ("ARM: at91: add new SoC sama7g5"),
> verified that it compiles and rebased the at91-soc branch on it. The commit
> message is as follow (wrapped):
> 
> ARM: at91: add new SoC sama7g5
> 
> Add new SoC from at91 family : sama7g5
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
> [claudiu.beznea@xxxxxxxxxxxxx: Select PLL, generic clock and UTMI support,
> add PM configs]
> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> Link:
> https://lore.kernel.org/r/20210409113116.482199-1-eugen.hristev@xxxxxxxxxxxxx
> Link:
> https://lore.kernel.org/r/20210719080317.1045832-2-claudiu.beznea@xxxxxxxxxxxxx
> 
> 
> Added lore link will allow us to trace this part of the discussion.
> Here is the new branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git/log/?h=at91-soc
> 
> Tell me if it's good for you.

Hi Nicolas,

It's good for me.

Thank you,
Claudiu

> 
> Thanks for having fixed that so quickly. Best regards,
>   Nicolas
> 
>