Re: [PATCH] PCI: endpoint: Use sysfs_emit() in "show" functions

[Kunihiko Hayashi]

Hi Krzysztof,

On 2021/07/20 0:18, Krzysztof Wilczy?ski wrote:
> [+cc Sasha for visibility]
>
> Hi!
>
> [...]
>>> Nice catch!
>>
>> I actually executed "cat" against configfs to meet the issue and found
>> your solution in pci-sysfs.
>
> Oh!  That's not good...  I am curious, which attribute caused this?

Sorry I misunderstood.

I found this "cat" issue on next-20210713 and all configfs attribues had
the same issue.

However, my patch wasn't the solution for the issue. This has been fixed by
7fe1e79b59ba ("configfs: implement the .read_iter and .write_iter methods").

The function replacement was found in the process of finding the issue.

> Also, if this is fixing a bug, then it might warrant letting the folks who look
> after the long-term and stable kernels know.  I also wonder if there would be
> something to add for the "Fixes:" tag, if there is a previous commit this
> change fixes.

So my patch doesn't fix any issues.

Thank you,

---
Best Regards
Kunihiko Hayashi