Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry()

[Mike Rapoport]

On Thu, Jul 15, 2021 at 04:35:08AM +0100, Matthew Wilcox (Oracle) wrote:
> Convert __lock_page_or_retry() to __folio_lock_or_retry().  This actually
> saves 4 bytes in the only caller of lock_page_or_retry() (due to better
> register allocation) and saves the 14 byte cost of calling page_folio()
> in __folio_lock_or_retry() for a total saving of 18 bytes.  Also use
> a bool for the return type.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Reviewed-by: William Kucharski <william.kucharski@xxxxxxxxxx>
> ---
>  include/linux/pagemap.h | 11 +++++++----
>  mm/filemap.c            | 20 +++++++++-----------
>  mm/memory.c             |  8 ++++----
>  3 files changed, 20 insertions(+), 19 deletions(-)

Acked-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>