Re: [PATCH v2] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()

From: Xianting Tian
Date: Tue Jul 20 2021 - 07:06:10 EST

在 2021/7/20 下午6:23, Stefan Hajnoczi 写道:
On Tue, Jul 20, 2021 at 03:13:37PM +0800, Xianting Tian wrote:
Add the missed virtio_device_ready() to set vsock frontend ready.

Signed-off-by: Xianting Tian<xianting.tian@xxxxxxxxxxxxxxxxx>
net/vmw_vsock/virtio_transport.c | 2 ++
1 file changed, 2 insertions(+)
Please include a changelog when you send v2, v3, etc patches.
OK, thanks.
diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
index e0c2c992a..dc834b8fd 100644
--- a/net/vmw_vsock/virtio_transport.c
+++ b/net/vmw_vsock/virtio_transport.c
@@ -639,6 +639,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
+ virtio_device_ready(vdev);
Why is this patch necessary?

Sorry, I didn't notice the check in virtio_dev_probe(),

As Jason comment,  I alsoe think we need to be consistent: switch to use virtio_device_ready() for all the drivers. What's opinion about this?

The core virtio_dev_probe() code already calls virtio_device_ready for

static int virtio_dev_probe(struct device *_d)
err = drv->probe(dev);
if (err)
goto err;
/* If probe didn't do it, mark device DRIVER_OK ourselves. */
if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))