Re: [PATCH 00/13] mtd: spinand: Add Octal DTR SPI (8D-8D-8D) mode support

[Nandan, Apurva]

On 13-Jul-21 6:35 PM, Apurva Nandan wrote:
> Hi,
> This series proposes patches for adding the following functionality
> in SPI NAND core:
> 
> - Octal DTR SPI (8D-8D-8D) mode support
> 
> - Winbond W35N01JW SPI NAND chip support
> 
> - Power-on-Reset instruction support
> 
> This series has been tested on TI J721e EVM with the Winbond W35N01JW
> flash with following test utilities:
> 
> - nandtest
>   Test log: https://textbin.net/raw/fhypoz63f9
> 
> - mtd_stresstest
>   Test log: https://textbin.net/raw/0xqjmqntj7
> 
> - UBIFS LTP stress test (NAND_XL_STRESS_DD_RW_UBIFS).
>   Test log: https://textbin.net/raw/pyokws7wku
> 
> Datasheet: https://www.winbond.com/export/sites/winbond/datasheet/W35N01JW_Datasheet_Brief.pdf
> 
> Apurva Nandan (13):
>   spi: spi-mem: Add DTR templates for cmd, address, dummy and data phase
>   mtd: spinand: Add enum spinand_proto to indicate current SPI IO mode
>   mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto
>   mtd: spinand: Fix odd byte addr and data phase in read/write reg op
>     and write VCR op for Octal DTR mode
>   mtd: spinand: Add adjust_op() in manufacturer_ops to modify the ops
>     for manufacturer specific changes
>   mtd: spinand: Add macros for Octal DTR page read and write operations
>   mtd: spinand: Allow enabling Octal DTR mode in the core
>   mtd: spinand: Reject 8D-8D-8D op_templates if octal_dtr_enale() is
>     missing in manufacturer_op
>   mtd: spinand: Add support for write volatile configuration register op
>   mtd: spinand: Add octal_dtr_enable() for Winbond manufacturer_ops
>   mtd: spinand: Add support for Power-on-Reset (PoR) instruction
>   mtd: spinand: Perform Power-on-Reset when runtime_pm suspend is issued
>   mtd: spinand: Add support for Winbond W35N01JW SPI NAND flash
> 
>  drivers/mtd/nand/spi/core.c    | 196 +++++++++++++++++++++++++++++++--
>  drivers/mtd/nand/spi/winbond.c | 186 +++++++++++++++++++++++++++++--
>  include/linux/mtd/spinand.h    |  67 +++++++++++
>  include/linux/spi/spi-mem.h    |  87 ++++++++++-----
>  4 files changed, 494 insertions(+), 42 deletions(-)
> 

Hi,
Can anyone please provide some comments/suggestions/reviews?

Thanks,
Apurva Nandan