Re: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets

[Bjorn Helgaas]

On Tue, Jul 20, 2021 at 09:50:25AM +0200, Christoph Hellwig wrote:
> > +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> > +{
> > +	/*
> > +	 * Simple invocations do not provide a calc_sets() callback. Call
> > +	 * the generic one.
> > +	 */
> > +	if (!affd->calc_sets)
> > +		default_calc_sets(affd, affvecs);
> > +	else
> > +		affd->calc_sets(affd, affvecs);
> 
> Nit: avoid pointless negations:
> 
> 	if (affd->calc_sets)
> 		affd->calc_sets(affd, affvecs);
> 	else
> 		default_calc_sets(affd, affvecs);

+1

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks for doing this!  For the PCI part:

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>