Re: [PATCH v4] iomap: support tail packing inline read

From: Andreas Grünbacher
Date: Tue Jul 20 2021 - 22:27:15 EST

Am Mi., 21. Juli 2021 um 02:33 Uhr schrieb Gao Xiang
> > And since you can only kmap one page at a time, an inline read grabs the
> > first part of the data in "page one" and then we have to call
> > iomap_begin a second time get a new address so that we can read the rest
> > from "page two"?
> Nope, currently EROFS inline data won't cross page like this.
> But in principle, yes, I don't want to limit it to the current
> EROFS or gfs2 usage. I think we could make this iomap function
> more generally (I mean, I'd like to make the INLINE extent
> functionity as general as possible,

Nono. Can we please limit this patch what we actually need right now,
and worry about extending it later?

> my v1 original approach
> in principle can support any inline extent in the middle of
> file rather than just tail blocks, but zeroing out post-EOF
> needs another iteration) and I don't see it add more code and
> complexity.