Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions

[Leon Romanovsky]

On Wed, Jul 21, 2021 at 07:45:48AM +0100, Christoph Hellwig wrote:
> > +/**
> > + * ib_create_qp_kernel - Creates a kernel QP associated with the specified
> 
> Any reason this function is renamed?  This seems rather unrelated to
> the rest of th patch.

I wanted to make two functions: ib_create_qp_kernel and ib_create_qp_user.

> 
> > + *   protection domain.
> >   * @pd: The protection domain associated with the QP.
> >   * @qp_init_attr: A list of initial attributes required to create the
> >   *   QP.  If QP creation succeeds, then the attributes are updated to
> >   *   the actual capabilities of the created QP.
> >   * @caller: caller's build-time module name
> > - *
> > - * NOTE: for user qp use ib_create_qp_user with valid udata!
> >   */
> 
> Also a kerneldoc comment for a function that is an implementation
> detail is actively harmful.  Please document ib_create_qp instead.

Sure, will do.