Re: [PATCH v2] tty: nozomi: tty_unregister_device -> tty_port_unregister_device

[Johan Hovold]

On Wed, Jul 21, 2021 at 07:33:04PM +0800, Dongliang Mu wrote:
> The pairwise api invocation of tty_port_register_device should be
> tty_port_unregister_device, other than tty_unregister_device.

Are you sure about that? Please explain why you think this to be the
case and why this change is needed.

> Fixes: a6afd9f3e819 ("tty: move a number of tty drivers from drivers/char/ to drivers/tty/")

Please try a little harder, that's clearly not the commit that changed
to the port registration helper.

> Cc: stable@xxxxxxxxxxxxxxx

Why do you think this is stable material? (hint: it is not)

> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> ---
>  drivers/tty/nozomi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
> index 0c80f25c8c3d..08bdd82f60b5 100644
> --- a/drivers/tty/nozomi.c
> +++ b/drivers/tty/nozomi.c
> @@ -1417,7 +1417,8 @@ static int nozomi_card_init(struct pci_dev *pdev,
>  
>  err_free_tty:
>  	for (i--; i >= 0; i--) {
> -		tty_unregister_device(ntty_driver, dc->index_start + i);
> +		tty_port_unregister_device(&dc->port[i].port, ntty_driver,
> +				dc->index_start + i);
>  		tty_port_destroy(&dc->port[i].port);
>  	}
>  	free_irq(pdev->irq, dc);

Johan