Re: [net,v6] net: stmmac: fix 'ethtool -P' return -EBUSY

[kernel test robot]

Hi Hao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc2 next-20210721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8cae8cd89f05f6de223d63e6d15e31c8ba9cf53b
config: arm64-randconfig-r022-20210720 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c781eb153bfbd1b52b03efe34f56bbeccbb8aba6)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/c55b4adeb427ae7db9fb2942a7bc7958a8d667bd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413
        git checkout c55b4adeb427ae7db9fb2942a7bc7958a8d667bd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:378:7: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
                   u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
                       ^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:418:35: error: incompatible pointer types passing 'struct net_device *' to parameter of type 'struct device *' [-Werror,-Wincompatible-pointer-types]
           return pm_runtime_resume_and_get(dev);
                                            ^~~
   include/linux/pm_runtime.h:400:60: note: passing argument to parameter 'dev' here
   static inline int pm_runtime_resume_and_get(struct device *dev)
                                                              ^
   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:22: warning: unused variable 'priv' [-Wunused-variable]
           struct stmmac_priv *priv = netdev_priv(dev);
                               ^
   2 warnings and 1 error generated.


vim +418 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

   413	
   414	static int stmmac_ethtool_begin(struct net_device *dev)
   415	{
   416		struct stmmac_priv *priv = netdev_priv(dev);
   417	
 > 418		return pm_runtime_resume_and_get(dev);
   419	}
   420	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip