Re: [PATCH v3 3/3] fs: simplify get_filesystem_list / get_all_fs_names

From: Stefan Hajnoczi
Date: Wed Jul 21 2021 - 11:46:40 EST


On Wed, Jul 14, 2021 at 04:23:21PM -0400, Vivek Goyal wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> Just output the '\0' separate list of supported file systems for block
> devices directly rather than going through a pointless round of string
> manipulation.
>
> Based on an earlier patch from Al Viro <viro@xxxxxxxxxxxxxxxxxx>.
>
> Vivek:
> Modified list_bdev_fs_names() and split_fs_names() to return number of
> null terminted strings to caller. Callers now use that information to
> loop through all the strings instead of relying on one extra null char
> being present at the end.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
> ---
> fs/filesystems.c | 27 +++++++++++++++----------
> include/linux/fs.h | 2 +-
> init/do_mounts.c | 49 ++++++++++++++++++++--------------------------
> 3 files changed, 39 insertions(+), 39 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature