Re: [PATCH -V11 8/9] mm/vmscan: never demote for memcg reclaim

From: Zi Yan
Date: Wed Jul 21 2021 - 17:38:55 EST

On 21 Jul 2021, at 2:39, Huang Ying wrote:

> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Global reclaim aims to reduce the amount of memory used on a given node or
> set of nodes. Migrating pages to another node serves this purpose.
> memcg reclaim is different. Its goal is to reduce the total memory
> consumption of the entire memcg, across all nodes. Migration does not
> assist memcg reclaim because it just moves page contents between nodes
> rather than actually reducing memory consumption.
> Link:
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
> Suggested-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Yang Shi <shy828301@xxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Wei Xu <weixugc@xxxxxxxxxx>
> Cc: Oscar Salvador <osalvador@xxxxxxx>
> Cc: Zi Yan <ziy@xxxxxxxxxx>
> Cc: David Rientjes <rientjes@xxxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: Greg Thelen <gthelen@xxxxxxxxxx>
> Cc: Keith Busch <kbusch@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> mm/vmscan.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)

LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>.

Should this be folded into Patch 4 when can_demote() is introduced?

Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature