Re: [PATCH v1 1/1] serial: max310x: Use clock-names property matching to recognize XTAL

[Andy Shevchenko]

On Thu, Jul 22, 2021 at 06:02:33PM +0300, Andy Shevchenko wrote:
> Dennis reported that on ACPI-based systems the clock frequency
> isn't enough to configure device properly. We have to respect
> the clock source as well. To achieve this match the clock-names
> property against "xtal" to recognize crystal connection.

Dennis, please test this.

...

> -	s->clk = devm_clk_get_optional(dev, "osc");
> +	xtal = device_property_match_string(dev, "clock-names", "xtal") >= 0;

Meanwhile I will change this (not affects the testing in your case) to actually
negative one as:

	..., "osc") < 0;

to be compatible with the original flow (in case there are two clock names, the
"osc" has a priority).


-- 
With Best Regards,
Andy Shevchenko