Re: [PATCH v4] media: atomisp: fix the uninitialized use and rename "retvalue"

From: Dan Carpenter
Date: Fri Jul 23 2021 - 04:11:15 EST

On Fri, Jul 23, 2021 at 12:36:04AM +0000, Yizhuo wrote:
> Inside function mt9m114_detect(), variable "retvalue" could
> be uninitialized if mt9m114_read_reg() returns error, however, it
> is used in the later if statement, which is potentially unsafe.
> The local variable "retvalue" is renamed to "model" to avoid
> confusion.
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> Signed-off-by: Yizhuo <yzhai003@xxxxxxx>
> ---

Is your full name just Yizhuo or Yizhuo Zhai? Please use your legal
name as if you were signing a legal document.

I don't think you have changed anything in this version? It's basically
a resend of the patch from Jun 25? Please put that information under
the --- cut off.

Looks okay to me.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

dan carpenter