RE: [PATCH v3 1/2] ASoC: amd: Don't show messages about deferred probing by default
From: Limonciello, Mario
Date: Fri Jul 23 2021 - 09:04:57 EST
[Public]
>
> On Thu, Jul 22, 2021 at 08:27:27AM -0500, Mario Limonciello wrote:
>
> > This isn't useful to a user, especially as probing will run again.
> > Use the dev_err_probe helper to hide the deferrerd probing messages.
>
> The reason we have these error messages is that they are very useful to
> users if they ever find that the device isn't instantiating due to some
> missing dependency or something that leaves it stuck in probe deferral,
> they give some hint as to what might be wrong.
Right, but they should be at debugging level, if someone has a problem they
turn on dynamic debugging for the module and then can see these messages.
To reinforce my point - that's what the drivers in patch 2/2 do already (but are
being moved to this helper) and furthermore this was in result to some reports
looking at this message in bootup thinking it was a problem but it being a red
herring.