Re: [PATCH 2/3] syscon: add support for "syscon-smc" compatible

From: kernel test robot
Date: Sat Jul 24 2021 - 03:00:44 EST


Hi "Clément,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on regmap/for-next]
[also build test WARNING on robh/for-next v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5b8123662c54263f6fc86b6ef9e296739fe78353
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
git checkout 5b8123662c54263f6fc86b6ef9e296739fe78353
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/mfd/syscon.c: In function 'syscon_probe':
>> drivers/mfd/syscon.c:407:23: warning: variable 'syscon_config' set but not used [-Wunused-but-set-variable]
407 | struct regmap_config syscon_config = syscon_regmap_config;
| ^~~~~~~~~~~~~


vim +/syscon_config +407 drivers/mfd/syscon.c

401
402 static int syscon_probe(struct platform_device *pdev)
403 {
404 int ret;
405 struct device *dev = &pdev->dev;
406 struct syscon_platform_data *pdata = dev_get_platdata(dev);
> 407 struct regmap_config syscon_config = syscon_regmap_config;
408 struct syscon *syscon;
409 const struct syscon_driver_data *driver_data;
410
411 if (pdata)
412 syscon_config.name = pdata->label;
413
414 syscon = devm_kzalloc(dev, sizeof(*syscon), GFP_KERNEL);
415 if (!syscon)
416 return -ENOMEM;
417
418 driver_data = (const struct syscon_driver_data *)
419 platform_get_device_id(pdev)->driver_data;
420
421 ret = driver_data->probe_func(pdev, dev, syscon);
422 if (ret)
423 return ret;
424
425 platform_set_drvdata(pdev, syscon);
426
427 return 0;
428 }
429

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip