Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting

From: Geraldo Nascimento
Date: Sat Jul 24 2021 - 14:04:25 EST


On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> This looks like a regression introduced by the recent commit
> d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock
> selector"), which is a fix for certain devices. Too bad that the
> behavior really depends on the device...

Dr. Iwai, perhaps we could restrict the generalized fix for the
Behringer UFX1604 / UFX1204 with some simple logic to devices that
only have *one* clock source.

In that case the clock selector must be set to the only clock source.

This way we keep the generalization without breaking devices with more
than one clock source.

Just an idea.

Thank you,
Geraldo Nascimento