Re: [PATCH v2 0/2] Abrupt Shutdown for NVMe SSD

[Keith Busch]

On Mon, Jul 26, 2021 at 01:22:21PM +0000, shiva.linuxworks@xxxxxxxxx wrote:
> In the platform with a limited backup power supply, devices like NVMe
> SSD does unsafe shutdown.
> 
> These two patches address this issue by adding a power loss imminent
> flag. The platform will enable the power loss imminent flag if the
> platform's power is running on the limited backup power supply. During
> the shutdown, the driver checks this information and pwerforms the
> abrupt shutdown.

I think the pm framework and nvme usage are ok, but you need a platform
specific caller to set the new power loss flag before this should be
considered, otherwise this is just unreachable code.