Re: [RFC PATCH v2 1/3] misc_cgroup: add support for nofile limit

From: Tejun Heo
Date: Mon Jul 26 2021 - 17:27:41 EST


On Thu, Jul 22, 2021 at 11:20:17PM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@xxxxxxxxxxx>
>
> Since the global open files are limited, in order to avoid the
> abnormal behavior of some containers from generating too many
> files, causing other containers to be unavailable, we need to
> limit the open files of some containers.
>
> v2: fix compile error while CONFIG_CGROUP_MISC not set.
>
> Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>

This is different from pid in that there's no actual limit on how many open
files there can be in the system other than the total amount of available
memory. I don't see why this would need a separate limit outside of memory
control. A couple machines I looked at all have file-max at LONG_MAX by
default too.

Thanks.

--
tejun