Re: [External] : Re: [PATCH] 9p/xen: Fix end of loop tests for list_for_each_entry

From: asmadeus
Date: Mon Jul 26 2021 - 20:00:26 EST


Stefano Stabellini wrote on Mon, Jul 26, 2021 at 04:54:29PM -0700:
> > > Yes, I did test it successfully. Aside from the commit messaged to be
> > > reworded:
> > How's this?
> > ===========================BEGIN========================================
> > 9p/xen: Fix end of loop tests for list_for_each_entry
> >
> > This patch addresses the following problems:
> > - priv can never be NULL, so this part of the check is useless
> > - if the loop ran through the whole list, priv->client is invalid and
> > it is more appropriate and sufficient to check for the end of
> > list_for_each_entry loop condition.
> >
> > Signed-off-by: Harshvardhan Jha <harshvardhan.jha@xxxxxxxxxx>

Will take the patch with this text as commit message later tonight


> > > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > > Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Thanks for the test!

--
Dominique