Re: [PATCH] virt: acrn: Do hcall_destroy_vm() before resource release

From: Greg Kroah-Hartman
Date: Tue Jul 27 2021 - 10:50:02 EST


On Thu, Jul 22, 2021 at 02:27:36PM +0800, Fei Li wrote:
> From: Shuo Liu <shuo.a.liu@xxxxxxxxx>
>
> The ACRN hypervisor has scenarios which could run a real-time guest VM.
> The real-time guest VM occupies dedicated CPU cores, be assigned with
> dedicated PCI devices. It can run without the Service VM after boot up.
> hcall_destroy_vm() returns failure when a real-time guest VM refuses.
> The clearing of flag ACRN_VM_FLAG_DESTROYED causes some kernel resource
> double-freed in a later acrn_vm_destroy().
>
> Do hcall_destroy_vm() before resource release to drop this chance to
> destroy the VM if hypercall fails.
>
> Fixes: 9c5137aedd11 ("virt: acrn: Introduce VM management interfaces")
> Signed-off-by: Shuo Liu <shuo.a.liu@xxxxxxxxx>
> Signed-off-by: Fei Li <fei1.li@xxxxxxxxx>
> ---

Do you also want this backported to older kernels? If so, you need to
put a cc: stable in here, right? I'll go add it myself, but be more
careful next time please.

greg k-h