Re: [PATCH net-next v3 06/31] phonet: use siocdevprivate

From: Rémi Denis-Courmont
Date: Tue Jul 27 2021 - 12:03:40 EST


Le tiistaina 27. heinäkuuta 2021, 16.44.52 EEST Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> phonet has a single private ioctl that is broken in compat
> mode on big-endian machines today because the data returned
> from it is never copied back to user space.
>
> Move it over to the ndo_siocdevprivate callback, which also
> fixes the compat issue.
>
> Cc: Remi Denis-Courmont <courmisch@xxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Rémi Denis-Courmont <courmisch@xxxxxxxxx>

--
This made me realise that the HSI/SSI device driver lacks the private IOCTL
(but that's obivously not a problem of this series).

--
Rémi Denis-Courmont
http://www.remlab.net/