Re: [PATCH] intersil: remove obsolete prism54 wireless driver

From: Kalle Valo
Date: Wed Jul 28 2021 - 10:55:29 EST


Luis Chamberlain <mcgrof@xxxxxxxxxx> writes:

> On Tue, Jul 27, 2021 at 09:07:48AM +0300, Kalle Valo wrote:
>> Christian Lamparter <chunkeey@xxxxxxxxx> writes:
>>
>> > On 16/07/2021 00:06, Luis Chamberlain wrote:
>> >> On Tue, Jul 13, 2021 at 07:40:25AM +0200, Lukas Bulwahn wrote:
>> >>> Commit 1d89cae1b47d ("MAINTAINERS: mark prism54 obsolete") indicated the
>> >>> prism54 driver as obsolete in July 2010.
>> >>>
>> >>> Now, after being exposed for ten years to refactoring, general tree-wide
>> >>> changes and various janitor clean-up, it is really time to delete the
>> >>> driver for good.
>> >>>
>> >>> This was discovered as part of a checkpatch evaluation, investigating all
>> >>> reports of checkpatch's WARNING:OBSOLETE check.
>> >>>
>> >>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
>> >>> ---
>> >
>> > noted. Farewell.
>>
>> How do we know that there are no users left? It's surprising how ancient
>> hardware some people use. Is the driver broken or what?
>>
>> (Reads commit 1d89cae1b47d)
>>
>> Ah, p54 is supposed to replace prism54. Does that include all the
>> hardware supported by prism54?
>
> There was a one off chipset someone told me about long ago that p54
> didn't work for. But that persond disappeared from the face of the
> earth. Additionally, distributions have been blacklisting prism54
> for years now.
>
>> If yes, that should be clearly documented
>> in the commit log and I can add that.
>
> Agreed. Feel free to quote the above.

Thanks, will do.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches