Re: [PATCH] KVM: SVM: delay svm_vcpu_init_msrpm after svm->vmcb is initialized

[Vineeth Pillai]

On 7/27/2021 11:23 AM, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:
>
> > Right now, svm_hv_vmcb_dirty_nested_enlightenments has an incorrect
> > dereference of vmcb->control.reserved_sw before the vmcb is checked
> > for being non-NULL.  The compiler is usually sinking the dereference
> > after the check; instead of doing this ourselves in the source,
> > ensure that svm_hv_vmcb_dirty_nested_enlightenments is only called
> > with a non-NULL VMCB.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > Cc: Vineeth Pillai <viremana@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > [Untested for now due to issues with my AMD machine. - Paolo]
Finally got hold of an AMD machine and tested nested virt: windows on 
linux on
windows with the patches applied. Did basic boot and minimal verification.

Tested-by: Vineeth Pillai <viremana@xxxxxxxxxxxxxxxxxxx>

Thanks,
Vineeth