Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup

[Shuah Khan]

On 7/29/21 11:16 AM, Bart Van Assche wrote:
> On 7/29/21 9:55 AM, Shuah Khan wrote:
> > On 7/29/21 10:52 AM, Bart Van Assche wrote:
> > > On 7/28/21 10:55 PM, Greg KH wrote:
> > > > On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote:
> > > > > Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
> > > > > Cc: David Gow <davidgow@xxxxxxxxxx>
> > > > > Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > > > > Cc: kunit-dev@xxxxxxxxxxxxxxxx
> > > > > Cc: linux-kselftest@xxxxxxxxxxxxxxx
> > > > > Cc: Bodo Stroesser <bostroesser@xxxxxxxxx>
> > > > > Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> > > > > Cc: Yanko Kaneti <yaneti@xxxxxxxxxxx>
> > > > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> > > > > ---
> > > >
> > > > I know I do not take patches without any changelog text.  Maybe other
> > > > maintainers are more lax :(
> > >
> > > Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory?
> >
> > I don't take patches without change logs either. I can't say the subject
> > tells me what you are doing.
> >
> > Please add a change log.
>
> I will add a changelog. But please note that this patch has been sent to Christoph as configfs maintainer.

Sure. This is a kunit patch - hence Kunit maintainers can comment on it.
Besides the comment is about missing change log which is rather basic
kernel dev 101.

Please take a look at Documentation/process/submitting-patches.rst
for information on commit logs.

thanks,
-- Shuah