Re: [PATCH V2 2/3] dt-bindings: arm: Add Thunder Bay bindings

[Rob Herring]

On Tue, Jul 20, 2021 at 10:52:48AM +0530, kenchappa.demakkanavar@xxxxxxxxx wrote:
> From: "Pan, Kris" <kris.pan@xxxxxxxxx>

Kris Pan <kris.pan@xxxxxxxxx>

> 
> Document Intel Movidius SoC code-named Thunder Bay, along with the
> Thunder Bay Full and Prime configuration board.
> 
> Add maintainers for the new Intel Movidius SoC code-named Thunder Bay.
> 
> Signed-off-by: Pan, Kris <kris.pan@xxxxxxxxx>
> Signed-off-by: Demakkanavar, Kenchappa <kenchappa.demakkanavar@xxxxxxxxx>

"First name last name" here too.

> ---
>  .../devicetree/bindings/arm/intel,thunderbay.yaml   | 21 +++++++++++++++++++++
>  MAINTAINERS                                         |  5 +++++
>  2 files changed, 26 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml b/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> new file mode 100644
> index 0000000..2b9d5f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/intel,thunderbay.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Thunder Bay platform device tree bindings
> +
> +maintainers:
> +  - Demakkanavar, Kenchappa <kenchappa.demakkanavar@xxxxxxxxx>

ditto

> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - intel,thunderbay
> +      - const: intel,thunderbay

Not valid to have duplicate strings.

Like everyone else, you need $nodename schema here to define this is 
for the root node.

> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 503fd21..041f9a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1992,6 +1992,11 @@ S:	Maintained
>  F:	arch/arm/mach-pxa/stargate2.c
>  F:	drivers/pcmcia/pxa2xx_stargate2.c
>  
> +ARM/INTEL THUNDERBAY ARCHITECTURE
> +M:	Demakkanavar, Kenchappa <kenchappa.demakkanavar@xxxxxxxxx>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/arm/intel,thunderbay.yaml
> +
>  ARM/INTEL XSC3 (MANZANO) ARM CORE
>  M:	Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>
>  L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> -- 
> 2.7.4
> 
>