Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()

From: Sebastian Andrzej Siewior
Date: Fri Jul 30 2021 - 10:01:49 EST


On 2021-07-19 17:01:51 [+0206], John Ogness wrote:
> On 2021-07-19, chao.qin@xxxxxxxxx wrote:
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -3620,7 +3620,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
> > u64 diff;
> > u64 seq;
> >
> > - may_sleep = (preemptible() && !in_softirq());
> > + may_sleep = (preemptible() && !in_softirq()
> > + && (system_state >= SYSTEM_RUNNING));

I don't have more context but scheduling should work starting with
SYSTEM_SCHEDULING.

> >
> > seq = prb_next_seq(prb);
> >
> >

Sebastian