Re: [PATCH] firewire: ohci: make reg_(read|write) unsigned
From: Greg Kroah-Hartman
Date: Sun Aug 01 2021 - 02:26:58 EST
On Sat, Jul 31, 2021 at 12:41:12PM +0200, Jordy Zomer wrote:
> The reg_(read|write) functions used to
> take a signed integer as an offset parameter.
> The callers of this function only pass an unsigned integer to it.
> Therefore to make it obviously safe, let's just make this an unsgined
> integer as this is used in pointer arithmetics.
>
> Signed-off-by: Jordy Zomer <jordy@pwning.systems>
> ---
> drivers/firewire/ohci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Same thing should probably also be done in
drivers/firewire/init_ohci1394_dma.c for the same inline functions,
right?
Anyway, nice cleanup:
Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>