Re: [PATCH v3 0/3] Remove all strcpy() uses

[Andy Shevchenko]

On Sun, Aug 1, 2021 at 11:53 AM Len Baker <len.baker@xxxxxxx> wrote:
>
> strcpy() performs no bounds checking on the destination buffer. This
> could result in linear overflows beyond the end of the buffer, leading
> to all kinds of misbehaviors. So, this serie removes all strcpy uses
> from the "staging/fbtft" subsystem.
>
> Also, refactor the code a bit to follow the kernel coding-style and
> avoid unnecessary variable initialization.

I don't see patch 3 (even on lore.kernel.org).

Greg, Geert, does it make sense to move this driver outside of staging?
I would volunteer to maintain it there.

> Changelog v1 -> v2
> - Add two new commits to clean the code.
> - Use the "%*ph" format specifier instead of strscpy() function (Geert
>   Uytterhoeven)
>
> Changelog v2 -> v3
> - Change the initialization of the "j" variable in the "for" loop and
>   update the code accordingly (Andy Shevchenko).
> - Improve the commit message to inform that the "%*ph" replacement
>   won't cut output earlier than requested (Andy Shevchenko).
> - Don't remove the braces in the "if" statement due to the presence of
>   the comment (Geert Uytterhoeven).
>
> Len Baker (3):
>   staging/fbtft: Remove all strcpy() uses
>   staging/fbtft: Remove unnecessary variable initialization
>   staging/fbtft: Fix braces coding style
>
>  drivers/staging/fbtft/fbtft-core.c | 23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)
>
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko