Re: [PATCH 1/2] tty: hvc: pass DMA capable memory to put_chars()

From: kernel test robot
Date: Sun Aug 01 2021 - 07:50:42 EST


Hi Xianting,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on char-misc/char-misc-testing soc/for-next linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Xianting-Tian/tty-hvc-pass-DMA-capable-memory-to-put_chars/20210801-131800
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/b33d1f04db78e1bfa5d798b676bd1062e2d54afc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xianting-Tian/tty-hvc-pass-DMA-capable-memory-to-put_chars/20210801-131800
git checkout b33d1f04db78e1bfa5d798b676bd1062e2d54afc
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=sparc64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

drivers/tty/hvc/hvc_console.c: In function 'hvc_poll_put_char':
>> drivers/tty/hvc/hvc_console.c:888:14: error: 'ch' redeclared as different kind of symbol
888 | static char ch = ch;
| ^~
drivers/tty/hvc/hvc_console.c:883:73: note: previous definition of 'ch' was here
883 | static void hvc_poll_put_char(struct tty_driver *driver, int line, char ch)
| ~~~~~^~
>> drivers/tty/hvc/hvc_console.c:888:19: error: initializer element is not constant
888 | static char ch = ch;
| ^~


vim +/ch +888 drivers/tty/hvc/hvc_console.c

882
883 static void hvc_poll_put_char(struct tty_driver *driver, int line, char ch)
884 {
885 struct tty_struct *tty = driver->ttys[0];
886 struct hvc_struct *hp = tty->driver_data;
887 int n;
> 888 static char ch = ch;
889
890 do {
891 n = hp->ops->put_chars(hp->vtermno, &ch, 1);
892 } while (n <= 0);
893 }
894 #endif
895

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip