Re: [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings

[luoj]

On 2021-07-29 21:17, Andrew Lunn wrote:
> > @@ -23,7 +25,29 @@ properties:
> >      const: 0
> >
> >    reg:
> > -    maxItems: 1
> > +    maxItems: 2
> > +
> > +  clocks:
> > +    items:
> > +      - description: MDIO clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: gcc_mdio_ahb_clk
> > +
> > +  resets:
> > +    items:
> > +      - description: MDIO reset & GEPHY hardware reset
> > +
> > +  reset-names:
> > +    items:
> > +      - const: gephy_mdc_rst
> > +
> > +  phy-reset-gpios:
> > +    maxItems: 3
> > +    description:
> > +      The phandle and specifier for the GPIO that controls the RESET
> > +      lines of PHY devices on that MDIO bus.
>
> This is clearly not a rename. It is great you are adding missing
> properties, but please do it as a separate patch.
>
> 	    Andrew

> Hi Andrew, thanks for the comments, will separate it out in the next 
> patch set.