Re: [PATCH v2 1/4] nubus: Simplify check in remove callback

[Uwe Kleine-König]

Hello Finn,

On Sun, Aug 01, 2021 at 03:04:03PM +1000, Finn Thain wrote:
> On Fri, 30 Jul 2021, Uwe Kleine-König wrote:
> 
> > The driver core only calls a remove callback when the device was
> > successfully bound (aka probed) before. So dev->driver is never NULL and
> > the respective check can just be dropped.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> Acked-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
> 
> BTW, aside from nubus, zorro and superhyway you can find the same pattern
> in many other busses. You may want to patch the following methods too.
> 
> acpi_device_remove
> apr_device_remove
> ccwgroup_remove
> gio_device_remove
> hid_device_remove 
> ibmebus_bus_device_remove
> macio_device_remove
> memstick_device_remove
> ntb_remove
> pci_device_remove
> pnp_device_remove
> ps3_system_bus_remove
> rio_device_remove
> slim_device_remove
> soundbus_device_remove
> ssb_device_remove
> tifm_device_remove
> vdpa_dev_remove
> vmbus_remove

Did you find these by hand? Or using a coccinelle match?

Anyhow, thanks for the list, I'll add it to my todo list but if you're
motivated don't consider these cleanups as my property. (Please Cc: me
though to prevent duplicated effort.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature