Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations

[Pkshih]

On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The variables rtstatus and place are being initialized with a values
> that
> are never read, the initializations are redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index 76dd881ef9bb..4eaa40d73baf 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -681,7 +681,7 @@ static bool _rtl92d_phy_bb_config(struct
> ieee80211_hw *hw)
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_phy *rtlphy = &(rtlpriv->phy);
>  	struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
> -	bool rtstatus = true;
> +	bool rtstatus;
>  
>  	rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE, "==>\n");
>  	rtstatus = _rtl92d_phy_config_bb_with_headerfile(hw,
> @@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
>  		132, 134, 136, 138, 140, 149, 151, 153, 155,
>  		157, 159, 161, 163, 165
>  	};
> -	u8 place = chnl;
> +	u8 place;
>  
>  	if (chnl > 14) {
>  		for (place = 14; place < sizeof(channel_all); place++)
> {
> -- 
> 2.31.1
> 
> ------Please consider the environment before printing this e-mail.

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>