Re: [PATCH] net/mlx4: make the array states static const, makes object smaller

From: Leon Romanovsky
Date: Mon Aug 02 2021 - 04:44:36 EST


On Sun, Aug 01, 2021 at 04:37:42PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the array states on the stack but instead it
> static const. Makes the object code smaller by 79 bytes.
>
> Before:
> text data bss dec hex filename
> 21309 8304 192 29805 746d drivers/net/ethernet/mellanox/mlx4/qp.o
>
> After:
> text data bss dec hex filename
> 21166 8368 192 29726 741e drivers/net/ethernet/mellanox/mlx4/qp.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx4/qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>