Re: [PATCH -next, v2] selinux: correct the return value when loads initial sids

From: Paul Moore
Date: Mon Aug 02 2021 - 10:21:37 EST


On Wed, Jul 28, 2021 at 11:15 PM Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> wrote:
>
> It should not return 0 when SID 0 is assigned to isids.
> This patch fixes it.
>
> v2: remove the "out" label and return directly.
>
> Fixes: e3e0b582c321a ("selinux: remove unused initial SIDs and improve handling")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx>
> ---
> security/selinux/ss/policydb.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)

Thanks, this looks much better. I decided this is worth sending up to
Linus as a fix for the 5.14-rcX series so I've merged it into
selinux/stable-5.14 and I'll send it up to Linus later this week.

--
paul moore
www.paul-moore.com