Re: [PATCH] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock

From: Shakeel Butt
Date: Mon Aug 02 2021 - 10:32:17 EST


On Sun, Aug 1, 2021 at 7:28 PM Waiman Long <longman@xxxxxxxxxx> wrote:
>
> When mod_objcg_state() is called with a pgdat that is different from
> that in the obj_stock, the old lruvec data cached in obj_stock are
> flushed out. Unfortunately, they were flushed to the new pgdat and
> hence the wrong node, not the one cached in obj_stock.
>
> Fix that by flushing the data to the cached pgdat instead.
>
> Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp")
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>

After incorporating Michal's comments, you can add:

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>