Re: [PATCH v9] iomap: Support file tail packing

From: Darrick J. Wong
Date: Mon Aug 02 2021 - 17:58:39 EST


On Mon, Aug 02, 2021 at 08:15:41PM +0800, Gao Xiang wrote:
> Hi Andreas,
>
> On Sun, Aug 01, 2021 at 02:03:33PM +0200, Andreas Gruenbacher wrote:
> > On Tue, Jul 27, 2021 at 5:00 AM Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx> wrote:
>
> ...
>
> > > +static int iomap_write_begin_inline(struct inode *inode,
> > > + struct page *page, struct iomap *srcmap)
> > > +{
> > > + /* needs more work for the tailpacking case, disable for now */
> >
> > Nit: the comma should be a semicolon or period here.
>
> Sorry for some delay (busy in other things...)
>
> Yeah, that's fine to me, in English contexts it'd be better like that
> (there is some punctuation rule difference between languages.)
>
>
> Hi Darrick,
> Should I resend v10 for this punctuation change or could you kindly
> help revise this?
>
> (btw, would you mind set up a for-next iomap branch so I could rebase
> other EROFS patches on iomap for-next, thank you very much!)

Er... I'll send a group email shortly. Assembling the branch hasn't
been as straightforward as it usually is...

--D

> Thanks,
> Gao Xiang