Re: [PATCH] riscv: explicitly use symbol offsets for VDSO v2

From: kernel test robot
Date: Mon Aug 02 2021 - 19:15:17 EST

Hi Saleem,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Saleem-Abdulrasool/riscv-explicitly-use-symbol-offsets-for-VDSO-v2/20210803-050150
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 349a2d52ffe59b7a0c5876fa7ee9f3eaf188b830
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/82dd1f24fc79924938e3633ecf573c7973d938f6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Saleem-Abdulrasool/riscv-explicitly-use-symbol-offsets-for-VDSO-v2/20210803-050150
git checkout 82dd1f24fc79924938e3633ecf573c7973d938f6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=riscv

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_clock_gettime':
>> arch/riscv/kernel/vdso/vgettimeofday.c:16:9: error: implicit declaration of function '__cvdso_clock_gettime'; did you mean '__vdso_clock_gettime'? [-Werror=implicit-function-declaration]
16 | return __cvdso_clock_gettime(clock, ts);
| ^~~~~~~~~~~~~~~~~~~~~
| __vdso_clock_gettime
arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_gettimeofday':
>> arch/riscv/kernel/vdso/vgettimeofday.c:23:9: error: implicit declaration of function '__cvdso_gettimeofday'; did you mean '__vdso_gettimeofday'? [-Werror=implicit-function-declaration]
23 | return __cvdso_gettimeofday(tv, tz);
| ^~~~~~~~~~~~~~~~~~~~
| __vdso_gettimeofday
arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_clock_getres':
>> arch/riscv/kernel/vdso/vgettimeofday.c:30:9: error: implicit declaration of function '__cvdso_clock_getres'; did you mean '__vdso_clock_getres'? [-Werror=implicit-function-declaration]
30 | return __cvdso_clock_getres(clock_id, res);
| ^~~~~~~~~~~~~~~~~~~~
| __vdso_clock_getres
cc1: some warnings being treated as errors
--
arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_clock_gettime':
>> arch/riscv/kernel/vdso/vgettimeofday.c:16:9: error: implicit declaration of function '__cvdso_clock_gettime'; did you mean '__vdso_clock_gettime'? [-Werror=implicit-function-declaration]
16 | return __cvdso_clock_gettime(clock, ts);
| ^~~~~~~~~~~~~~~~~~~~~
| __vdso_clock_gettime
arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_gettimeofday':
>> arch/riscv/kernel/vdso/vgettimeofday.c:23:9: error: implicit declaration of function '__cvdso_gettimeofday'; did you mean '__vdso_gettimeofday'? [-Werror=implicit-function-declaration]
23 | return __cvdso_gettimeofday(tv, tz);
| ^~~~~~~~~~~~~~~~~~~~
| __vdso_gettimeofday
arch/riscv/kernel/vdso/vgettimeofday.c: In function '__vdso_clock_getres':
>> arch/riscv/kernel/vdso/vgettimeofday.c:30:9: error: implicit declaration of function '__cvdso_clock_getres'; did you mean '__vdso_clock_getres'? [-Werror=implicit-function-declaration]
30 | return __cvdso_clock_getres(clock_id, res);
| ^~~~~~~~~~~~~~~~~~~~
| __vdso_clock_getres
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:273: arch/riscv/kernel/vdso/vgettimeofday.o] Error 1
make[2]: Target 'include/generated/vdso-offsets.h' not remade because of errors.
make[1]: *** [arch/riscv/Makefile:114: vdso_prepare] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.


vim +16 arch/riscv/kernel/vdso/vgettimeofday.c

ad5d1122b82fbd Vincent Chen 2020-06-09 11
e93b327dbf3d37 Vincent Chen 2020-06-23 12 extern
e93b327dbf3d37 Vincent Chen 2020-06-23 13 int __vdso_clock_gettime(clockid_t clock, struct __kernel_timespec *ts);
ad5d1122b82fbd Vincent Chen 2020-06-09 14 int __vdso_clock_gettime(clockid_t clock, struct __kernel_timespec *ts)
ad5d1122b82fbd Vincent Chen 2020-06-09 15 {
ad5d1122b82fbd Vincent Chen 2020-06-09 @16 return __cvdso_clock_gettime(clock, ts);
ad5d1122b82fbd Vincent Chen 2020-06-09 17 }
ad5d1122b82fbd Vincent Chen 2020-06-09 18
e93b327dbf3d37 Vincent Chen 2020-06-23 19 extern
e93b327dbf3d37 Vincent Chen 2020-06-23 20 int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz);
ad5d1122b82fbd Vincent Chen 2020-06-09 21 int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
ad5d1122b82fbd Vincent Chen 2020-06-09 22 {
ad5d1122b82fbd Vincent Chen 2020-06-09 @23 return __cvdso_gettimeofday(tv, tz);
ad5d1122b82fbd Vincent Chen 2020-06-09 24 }
ad5d1122b82fbd Vincent Chen 2020-06-09 25
e93b327dbf3d37 Vincent Chen 2020-06-23 26 extern
e93b327dbf3d37 Vincent Chen 2020-06-23 27 int __vdso_clock_getres(clockid_t clock_id, struct __kernel_timespec *res);
ad5d1122b82fbd Vincent Chen 2020-06-09 28 int __vdso_clock_getres(clockid_t clock_id, struct __kernel_timespec *res)
ad5d1122b82fbd Vincent Chen 2020-06-09 29 {
ad5d1122b82fbd Vincent Chen 2020-06-09 @30 return __cvdso_clock_getres(clock_id, res);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip