RE: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies

From: Keller, Jacob E
Date: Mon Aug 02 2021 - 19:45:26 EST


> -----Original Message-----
> From: Richard Cochran <richardcochran@xxxxxxxxx>
> Sent: Monday, August 02, 2021 4:09 PM
> To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxxxx>; Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>;
> Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Kurt
> Kanzenbach <kurt@xxxxxxxxxxxxx>; Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>;
> Ertman, David M <david.m.ertman@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK
> dependencies
>
> On Mon, Aug 02, 2021 at 07:54:20PM +0000, Keller, Jacob E wrote:
> > So go back to "select"?
>
> Why not keep it simple?
>
> PTP core:
> Boolean PTP_1588_CLOCK
>
> drivers:
> depends on PTP_1588_CLOCK
>
> Also, make Posix timers always part of the core. Tinification is a
> lost cause.
>
> Thanks,
> Richard

Ok, so basically: if any driver that needs PTP core is on, PTP core is on, with no way to disable it.

Thanks,
Jake