RE: [PATCH net-next] net: fec: fix MAC internal delay doesn't work

[Joakim Zhang]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: 2021年8月3日 4:33
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; andrew@xxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work
> 
> On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
> > @@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
> >  		fep->phy_interface = interface;
> >  	}
> >
> > +	ret = fec_enet_parse_rgmii_delay(fep, np);
> > +	if (ret)
> > +		goto failed_phy;
> 
> You're jumping to the wrong label, it looks like phy_node needs to be released
> at this point.

Yes, I will correct it. Thanks Jakub.

Best Regards,
Joakim Zhang