RE: [PATCH] sched/debug: print column titles of show_state_filter()[V2]

[S, Shirish]

[Public]

Can we get this patch merged ?
Any thoughts?


Regards,
Shirish S

-----Original Message-----
From: S, Shirish <Shirish.S@xxxxxxx> 
Sent: Wednesday, July 14, 2021 8:57 AM
To: Ingo Molnar <mingo@xxxxxxxxxx>; Peter Zijlstra <peterz@xxxxxxxxxxxxx>; Juri Lelli <juri.lelli@xxxxxxxxxx>; Vincent Guittot <vincent.guittot@xxxxxxxxxx>; Dietmar Eggemann <dietmar.eggemann@xxxxxxx>; Steven Rostedt <rostedt@xxxxxxxxxxx>; Ben Segall <bsegall@xxxxxxxxxx>; Mel Gorman <mgorman@xxxxxxx>; Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx; S, Shirish <Shirish.S@xxxxxxx>
Subject: [PATCH] sched/debug: print column titles of show_state_filter()[V2]

This addition in the debug output shall improve readablitly..
Its not intuitive for users that the pid printed in last column is of parent process.

v2: Dropped #ifdef logic

Signed-off-by: Shirish S <shirish.s@xxxxxxx>
Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
 kernel/sched/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 2d9ff40f4661..22cee4c0f4b1 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8194,6 +8194,9 @@ void show_state_filter(unsigned int state_filter)  {
 	struct task_struct *g, *p;
 
+	pr_info("  task%*s", BITS_PER_LONG == 32 ? 38 : 46,
+		"PC stack   pid father\n");
+
 	rcu_read_lock();
 	for_each_process_thread(g, p) {
 		/*
--
2.17.1