Re: commit c7e88ecbe328 ("staging: r8188eu: remove rtw_buf_free() function")

From: Fabio M. De Francesco
Date: Tue Aug 03 2021 - 08:23:33 EST


On Tuesday, August 3, 2021 9:21:30 AM CEST Fabio Aiuto wrote:
>
> Do you have any idea of what happened? This
> topic could give us all deeper understanding
> of kernel memory management.
>
Hi Fabio,

I've just briefly looked at that c7e88ecbe328. I have no time to dig it deeper
but at a first look it seems that the following line is the culprit:

kfree(&pmlmepriv->assoc_req);

It should be:

kfree(pmlmepriv->assoc_req);

The second line frees the memory location whose address is saved in assoc_rec;
the first line instead frees assoc_req itself.

Regards,

Fabio