Re: [PATCH v2] sock: allow reading and changing sk_userlocks with setsockopt

From: Jakub Kicinski
Date: Tue Aug 03 2021 - 08:42:07 EST


On Tue, 3 Aug 2021 14:04:39 +0300 Pavel Tikhomirov wrote:
> > Just to double check - is the expectation that the value returned is
> > completely opaque to the user space? The defines in question are not
> > part of uAPI.
>
> Sorry, didn't though about it initially. For criu we don't care about
> the actual bits we restore same what we've dumped. Buf if some real
> users would like to use this interface to restore default autoadjustment
> on their sockets we should probably export SOCK_SNDBUF_LOCK and
> SOCK_RCVBUF_LOCK to uAPI.

Just to be sure - please mention this in the commit message.