Re: [PATCH v2 3/4] spi: mediatek: modify set_cs_timing callback

From: Mark Brown
Date: Tue Aug 03 2021 - 15:31:08 EST


On Tue, Aug 03, 2021 at 09:20:19PM +0300, Andy Shevchenko wrote:
> On Tue, Aug 3, 2021 at 1:42 PM Mason Zhang <Mason.Zhang@xxxxxxxxxxxx> wrote:

> > + inactive = inactive ? inactive : 1;

> All of these can be simplified by using ?: (short ternary) form.

Please don't, if anything just don't use the ternery operator at all for
things like this - it doesn't help with legibility.

Attachment: signature.asc
Description: PGP signature