Re: [PATCH 2/2] riscv: dts: microchip: Add ethernet0 to the aliases node

[Palmer Dabbelt]

On Fri, 16 Jul 2021 04:34:02 PDT (-0700), geert@xxxxxxxxxxxxxx wrote:
> Hi Bin,
>
> On Fri, Jul 16, 2021 at 12:14 PM Bin Meng <bmeng.cn@xxxxxxxxx> wrote:
> > On Fri, Jul 16, 2021 at 5:23 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > > On Fri, Jul 2, 2021 at 3:44 AM Bin Meng <bmeng.cn@xxxxxxxxx> wrote:
> > > > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > > > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> > > > @@ -9,6 +9,10 @@ / {
> > > >         model = "Microchip MPFS Icicle Kit";
> > > >         compatible = "microchip,mpfs-icicle-kit";
> > > >
> > > > +       aliases {
> > > > +               ethernet0 = &emac1;
> > > > +       };
> > > > +
> > > >         chosen {
> > > >         };
> > >
> > > This should be added to the board DTS (microchip-mpfs-icicle-kit.dts)
> > > instead.
> >
> > I was wondering the same thing before doing this, but when I checked
> > all other DTS in arch/riscv/boot I found the aliases node is put in
> > the SoC dtsi file instead of the board on so I think that's the
> > convention.
>
> The numbering of the aliases is supposed to match the labels on the
> board, hence it is board-specific, not SoC-specific.
>
> Gr{oetje,eeting}s,
>
>                         Geert

I don't see a v2 of this.