Re: [PATCH 3/5] ARM: dts: Add basic support for EcoNet EN7523

From: Bert Vermeulen
Date: Wed Aug 04 2021 - 12:42:19 EST

On 7/30/21 4:46 PM, Mark Rutland wrote:
On Fri, Jul 30, 2021 at 03:45:50PM +0200, Bert Vermeulen wrote:
+ timer {
+ compatible = "arm,armv8-timer";

This should be "arm,armv7-timer".

+ interrupt-parent = <&gic>;
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,

GICv3 doesn't have a cpumask in its PPI description, so the
GIC_CPU_MASK_SIMPLE() bits should be removed.

Ok, will fix.

+ clock-frequency = <25000000>;

Please have your FW configure CNTFRQ on each CPU; the clock-frequency
property in the DT is a workaround for broken FW, and it's *vastly*
preferable for FW to configure this correctly (e.g. as it means VMs
should "just work").

I've since got hold of the modified U-Boot that runs on my eval board, and indeed it doesn't set CNTFRQ. So the kernel does need this, for the moment.

I may get a chance to upstream support for this SoC in U-Boot, but I can't control what people are going to ship with their board. Is it ok to leave this in?

Bert Vermeulen