RE: [PATCH net-next v3] ethernet: fix PTP_1588_CLOCK dependencies

[Keller, Jacob E]

> -----Original Message-----
> From: Arnd Bergmann <arnd@xxxxxxxxxx>
> Sent: Wednesday, August 04, 2021 8:21 AM
> To: Richard Cochran <richardcochran@xxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>;
> Andrew Lunn <andrew@xxxxxxx>; Vivien Didelot <vivien.didelot@xxxxxxxxx>;
> Florian Fainelli <f.fainelli@xxxxxxxxx>; Vladimir Oltean <olteanv@xxxxxxxxx>;
> Claudiu Manoil <claudiu.manoil@xxxxxxx>; Alexandre Belloni
> <alexandre.belloni@xxxxxxxxxxx>; Microchip Linux Driver Support
> <UNGLinuxDriver@xxxxxxxxxxxxx>; Nicolas Ferre
> <nicolas.ferre@xxxxxxxxxxxxx>; Claudiu Beznea
> <claudiu.beznea@xxxxxxxxxxxxx>; Yisen Zhuang <yisen.zhuang@xxxxxxxxxx>;
> Salil Mehta <salil.mehta@xxxxxxxxxx>; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Tariq Toukan <tariqt@xxxxxxxxxx>; Saeed
> Mahameed <saeedm@xxxxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>; Jiri
> Pirko <jiri@xxxxxxxxxx>; Ido Schimmel <idosch@xxxxxxxxxx>; Shannon Nelson
> <snelson@xxxxxxxxxxx>; drivers@xxxxxxxxxxx; Sergei Shtylyov
> <sergei.shtylyov@xxxxxxxxx>; Edward Cree <ecree.xilinx@xxxxxxxxx>; Martin
> Habets <habetsm.xilinx@xxxxxxxxx>; Giuseppe Cavallaro
> <peppe.cavallaro@xxxxxx>; Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>;
> Jose Abreu <joabreu@xxxxxxxxxxxx>; Heiner Kallweit <hkallweit1@xxxxxxxxx>;
> Russell King <linux@xxxxxxxxxxxxxxx>; Yangbo Lu <yangbo.lu@xxxxxxx>; Randy
> Dunlap <rdunlap@xxxxxxxxxxxxx>; Simon Horman
> <simon.horman@xxxxxxxxxxxxx>; Networking <netdev@xxxxxxxxxxxxxxx>;
> Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Intel Wired LAN <intel-
> wired-lan@xxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH net-next v3] ethernet: fix PTP_1588_CLOCK dependencies
> 
> On Wed, Aug 4, 2021 at 4:28 PM Richard Cochran <richardcochran@xxxxxxxxx>
> wrote:
> > > @@ -87,8 +87,8 @@ config E1000E_HWTS
> > >  config IGB
> > >       tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support"
> > >       depends on PCI
> > > -     imply PTP_1588_CLOCK
> > > -     select I2C
> > > +     depends on PTP_1588_CLOCK_OPTIONAL
> > > +     depends on I2C
> >
> > This little i2c bit sneaks in, but I guess you considered any possible
> > trouble with it?
> 
> Good catch!
> 
> I did need this with v2, as it was causing a circular dependency against
> (IIRC) CONFIG_MLXSW_I2C, but I'm fairly sure it's not needed any
> more after everything else uses 'depends on' now.
> 
> I'm happy to resend a v4 without that change, as it doesn't belong in here,
> or we just leave it because it is correct after all, depending on what the Intel
> ethernet people prefer.
> 

I'm fine with keeping it in.

> > Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
> 
> Thanks,
> 
>       Arnd