Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent
From: Chao Yu
Date: Wed Aug 04 2021 - 20:29:56 EST
Jaegeuk,
On 2021/8/5 7:45, Jaegeuk Kim wrote:
Chao,
How about this?
https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0
Looks more clean, thanks,
I'm digging one bug in __insert_extent_tree w/ the patch tho.
Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
__try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
w/ uninitialized c_len of @ei.
On 08/04, Chao Yu wrote:
+ if (from_dnode)
+ goto skip_reading_dnode;
Wrong condition here, thanks for fixing.
Thanks,